Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 )
Change subject: [java] fix Kudu Ranger plugin in a Kerberized env ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/15414/1/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java: http://gerrit.cloudera.org:8080/#/c/15414/1/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@77 PS1, Line 77: // Determine if Kerberos is enabled in the Ranger service via Hadoop : // UserGroupInformation. Kerberos should be also enabled in Kudu master : // when using Ranger for authorization. : if (UserGroupInformation.isSecurityEnabled()) > Rather than saying what code is being run, could you describe what we're do Done http://gerrit.cloudera.org:8080/#/c/15414/1/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@81 PS1, Line 81: kuduPrincipal.isEmpty() || keytab.isEmpty() > Should we log what these are, or would that be bad from a security perspect Done. I don't think these are sensitive as we have non-sensitive gflags for these. http://gerrit.cloudera.org:8080/#/c/15414/1/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@94 PS1, Line 94: > nit: this kind of goes without saying Done http://gerrit.cloudera.org:8080/#/c/15414/1/java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java File java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java: http://gerrit.cloudera.org:8080/#/c/15414/1/java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java@26 PS1, Line 26: import org.junit.Assert; > Revert? Done -- To view, visit http://gerrit.cloudera.org:8080/15414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe043293ea9cc1c2f43a331603dc1e3b36ff6ae0 Gerrit-Change-Number: 15414 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 12 Mar 2020 06:08:46 +0000 Gerrit-HasComments: Yes
