Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 )
Change subject: [java] fix Kudu Ranger plugin in a Kerberized env ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/15414/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerProtocolHandler.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerProtocolHandler.java: http://gerrit.cloudera.org:8080/#/c/15414/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerProtocolHandler.java@47 PS2, Line 47: Preconditions.checkNotNull(kuduPrincipal); What about unsecured environments? Or is that really not possible? http://gerrit.cloudera.org:8080/#/c/15414/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java: http://gerrit.cloudera.org:8080/#/c/15414/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@80 PS2, Line 80: if (UserGroupInformation.isSecurityEnabled()) { In the case kerberos isn't enabled should we let the principle and keytab be null? Maybe move the null check to the if statement below checking for isEmpty. http://gerrit.cloudera.org:8080/#/c/15414/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@88 PS2, Line 88: if (LOG.isDebugEnabled()) { You shouldn't need this given there in no expensive computation in the if statement and you are using slf4j message formatting. -- To view, visit http://gerrit.cloudera.org:8080/15414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe043293ea9cc1c2f43a331603dc1e3b36ff6ae0 Gerrit-Change-Number: 15414 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 12 Mar 2020 15:03:56 +0000 Gerrit-HasComments: Yes
