Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 )
Change subject: [java] fix Kudu Ranger plugin in a Kerberized env ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/15414/2//COMMIT_MSG Commit Message: PS2: I think the commit description to clarify that we're talking about a _Kerberized Ranger_. Keberized _environment_ is somewhat vague; yes, there's a good chance that if Ranger is Kerberized, so is Kudu, but for the purpose of understanding the behavior of the patch, what's critical is Ranger's Kerberization, not Kudu's. http://gerrit.cloudera.org:8080/#/c/15414/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessConfiguration.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessConfiguration.java: http://gerrit.cloudera.org:8080/#/c/15414/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessConfiguration.java@40 PS2, Line 40: KEY_TAB Nit: KEYTAB http://gerrit.cloudera.org:8080/#/c/15414/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerProtocolHandler.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerProtocolHandler.java: http://gerrit.cloudera.org:8080/#/c/15414/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerProtocolHandler.java@47 PS2, Line 47: Preconditions.checkNotNull(kuduPrincipal); > What about unsecured environments? Or is that really not possible? Yeah I think we should decouple this module from Kerberization, since using Ranger for authz isn't really dependent on Kerberization, right? -- To view, visit http://gerrit.cloudera.org:8080/15414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe043293ea9cc1c2f43a331603dc1e3b36ff6ae0 Gerrit-Change-Number: 15414 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 12 Mar 2020 22:52:04 +0000 Gerrit-HasComments: Yes
