Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15416 )
Change subject: [ranger] pass 'principal' and 'keytab' to the subprocess ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15416/2/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15416/2/src/kudu/ranger/ranger_client.cc@150 PS2, Line 150: { FLAGS_java_path, "-cp", GetJavaClasspath(), kMainClass, : "-i", GetKuduPrincipal(), "-k", FLAGS_keytab_file } > nit: It feels kind of weird to be passing -i and -k unconditionally. +1; at the very least, shouldn't we NOT pass these args if Kudu isn't Kerberized? http://gerrit.cloudera.org:8080/#/c/15416/2/src/kudu/security/init.cc File src/kudu/security/init.cc: http://gerrit.cloudera.org:8080/#/c/15416/2/src/kudu/security/init.cc@441 PS2, Line 441: const auto& kHostToken = "_HOST"; This can be made static. -- To view, visit http://gerrit.cloudera.org:8080/15416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie30b835b6d44ddb51d95c587f1329bfefebeb37c Gerrit-Change-Number: 15416 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 12 Mar 2020 22:45:25 +0000 Gerrit-HasComments: Yes
