Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15416 )
Change subject: [ranger] pass 'principal' and 'keytab' to the subprocess ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15416/4/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15416/4/src/kudu/ranger/ranger_client.cc@130 PS4, Line 130: : static bool ValidateRangerJavaPath() { : if (!FLAGS_ranger_config_path.empty() && : !Env::Default()->FileExists(FLAGS_ranger_java_path)) { : LOG(ERROR) << Substitute("FLAGS_ranger_java_path has invalid java binary path: $0", : FLAGS_ranger_java_path); : return false; : } : return true; : } : GROUP_FLAG_VALIDATOR(ranger_java_path_flags, ValidateRangerJavaPath); : : static bool ValidateRangerJarPath() { : if (!FLAGS_ranger_config_path.empty() && : !Env::Default()->FileExists(FLAGS_ranger_jar_path)) { : LOG(ERROR) << Substitute("FLAGS_ranger_jar_path has invalid JAR file path for the " : "Ranger subprocess: $0", FLAGS_ranger_jar_path); : return false; : } : return true; : } : GROUP_FLAG_VALIDATOR(ranger_jar_path_flags, ValidateRangerJarPath); > Not sure if we do this elsewhere, but would it make sense to do all this va Yeah, makes sense, will update it in the other patch where this validation is introduced. -- To view, visit http://gerrit.cloudera.org:8080/15416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie30b835b6d44ddb51d95c587f1329bfefebeb37c Gerrit-Change-Number: 15416 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 15 Mar 2020 04:19:19 +0000 Gerrit-HasComments: Yes
