Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15416 )
Change subject: [ranger] pass 'principal' and 'keytab' to the subprocess ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/15416/3/src/kudu/ranger/ranger_client.h File src/kudu/ranger/ranger_client.h: http://gerrit.cloudera.org:8080/#/c/15416/3/src/kudu/ranger/ranger_client.h@101 PS3, Line 101: } // namespace ranger : } // namespace kudu : : : > Maybe just put this in an anonymous namespace in the .cc file? Then we don' Done http://gerrit.cloudera.org:8080/#/c/15416/3/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15416/3/src/kudu/ranger/ranger_client.cc@371 PS3, Line 371: > nit: Remove std. Done http://gerrit.cloudera.org:8080/#/c/15416/3/src/kudu/ranger/ranger_client.cc@385 PS3, Line 385: r (const auto& action : *actions) { : auto req = req_list.add_requests(); : req->set_action(action); : req->set_database(db); : req->set_table(tbl.ToString()); : } > nit: Why not just RETURN_NOT_OK_PREPEND? Done http://gerrit.cloudera.org:8080/#/c/15416/3/src/kudu/ranger/ranger_client.cc@372 PS3, Line 372: string db; : Slice tbl; : : auto s = ParseRangerTableIdentifier(table_name, &db, &tbl); : if (PREDICT_FALSE(!s.ok())) { : LOG(WARNING) << Substitute(kDenyNonRangerTableTemplate, table_name); : return Status::NotAuthorized(kUnauthorizedAction); : } : : RangerRequestListPB req_list; : RangerResponseListPB resp_list; : req_list.set_user(user_name); : : for (const auto& action : *actions) { : auto req = req_list.add_requests(); : req->set_action(action); : req->set_database(db); : req->set_table(tbl.ToString()); : } : : RETURN_NOT_OK(subprocess_->Execute(req_list, &resp_list)); : : DCHECK_EQ(actions->size(), resp_list.responses_size()); : > nit: It's generally less error-prone to only mutate an outparam if this suc Done -- To view, visit http://gerrit.cloudera.org:8080/15416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie30b835b6d44ddb51d95c587f1329bfefebeb37c Gerrit-Change-Number: 15416 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 15 Mar 2020 00:45:12 +0000 Gerrit-HasComments: Yes
