Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 )
Change subject: client: micro-optimizations to reduce CPU and allocations ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15439/1/src/kudu/client/resource_metrics-internal.h File src/kudu/client/resource_metrics-internal.h: http://gerrit.cloudera.org:8080/#/c/15439/1/src/kudu/client/resource_metrics-internal.h@47 PS1, Line 47: void Increment(StringPiece name, int64_t amount); nit: might be obvious, but maybe doc that this should only be used when we have some guarantee that the stringpiece will outlive these metrics? http://gerrit.cloudera.org:8080/#/c/15439/1/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/15439/1/src/kudu/client/schema.cc@826 PS1, Line 826: (Schema&& nit: pass by value and move? -- To view, visit http://gerrit.cloudera.org:8080/15439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I705aef9f2e57d44f387b58650279130ff329666d Gerrit-Change-Number: 15439 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 15 Mar 2020 09:00:30 +0000 Gerrit-HasComments: Yes
