Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 )
Change subject: client: micro-optimizations to reduce CPU and allocations ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15439/3/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/15439/3/src/kudu/client/client-internal.cc@36 PS3, Line 36: #include <boost/container/vector.hpp> > Do we need this? weirdly IWYU wants both of these http://gerrit.cloudera.org:8080/#/c/15439/3/src/kudu/client/resource_metrics-internal.h File src/kudu/client/resource_metrics-internal.h: http://gerrit.cloudera.org:8080/#/c/15439/3/src/kudu/client/resource_metrics-internal.h@28 PS3, Line 28: #include <sparsehash/dense_hash_set> > Remove? Surprised IWYU didn't complain about this. ah, I bet it didn't because it only defines non-instantiated templates? I seem to recall there is some weirdness about templates and IWYU -- To view, visit http://gerrit.cloudera.org:8080/15439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I705aef9f2e57d44f387b58650279130ff329666d Gerrit-Change-Number: 15439 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 20 Mar 2020 03:53:58 +0000 Gerrit-HasComments: Yes
