Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 )
Change subject: client: micro-optimizations to reduce CPU and allocations ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/15439/1/src/kudu/client/resource_metrics-internal.h File src/kudu/client/resource_metrics-internal.h: http://gerrit.cloudera.org:8080/#/c/15439/1/src/kudu/client/resource_metrics-internal.h@55 PS1, Line 55: int64_t GetMetric(const std::string& name) const; > went with a dense_hash_set instead Er, you went with std::set. Was that intentional? Or did you want dense_hash_set? http://gerrit.cloudera.org:8080/#/c/15439/2/src/kudu/client/resource_metrics.cc File src/kudu/client/resource_metrics.cc: http://gerrit.cloudera.org:8080/#/c/15439/2/src/kudu/client/resource_metrics.cc@29 PS2, Line 29: #include "kudu/client/resource_metrics-internal.h" Trailing whitespace here. http://gerrit.cloudera.org:8080/#/c/15439/1/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/15439/1/src/kudu/client/schema.h@718 PS1, Line 718: #if __cplusplus >= 201103 > added an ifdef around it for C++11. I think it's fine for it to just not sh Oh oops, Schema vs. KuduSchema. -- To view, visit http://gerrit.cloudera.org:8080/15439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I705aef9f2e57d44f387b58650279130ff329666d Gerrit-Change-Number: 15439 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 18 Mar 2020 23:25:27 +0000 Gerrit-HasComments: Yes
