Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15446
to review the following change.
Change subject: BloomFileTestBase: refactor test fixture
......................................................................
BloomFileTestBase: refactor test fixture
clang-tidy flags the gflag definitions in bloomfile-test-base.h for
potential ODR violations. To avoid that, let's move the bulk of the test
fixture into a new .cc file.
Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
---
M src/kudu/cfile/CMakeLists.txt
A src/kudu/cfile/bloomfile-test-base.cc
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/bloomfile-test.cc
4 files changed, 174 insertions(+), 95 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/15446/1
--
To view, visit http://gerrit.cloudera.org:8080/15446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0
Gerrit-Change-Number: 15446
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
