Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15446 )
Change subject: BloomFileTestBase: refactor test fixture ...................................................................... BloomFileTestBase: refactor test fixture clang-tidy flags the gflag definitions in bloomfile-test-base.h for potential ODR violations. To avoid that, let's move the bulk of the test fixture into a new .cc file. Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0 Reviewed-on: http://gerrit.cloudera.org:8080/15446 Reviewed-by: Andrew Wong <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/cfile/CMakeLists.txt A src/kudu/cfile/bloomfile-test-base.cc M src/kudu/cfile/bloomfile-test-base.h M src/kudu/cfile/bloomfile-test.cc 4 files changed, 173 insertions(+), 97 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0 Gerrit-Change-Number: 15446 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
