Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 )
Change subject: BloomFileTestBase: refactor test fixture ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15446/1//COMMIT_MSG Commit Message: PS1: > Do we need to do this for other header-defined metrics? Looking at diskrows Yeah probably. I just happened to be here because I was working in mt-bloomfile-test and clang-tidy flagged it. I'd rather not deal with the others right now though; the next person to touch those files can handle it. :) -- To view, visit http://gerrit.cloudera.org:8080/15446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2213ec39f08af8c36fa730598f2b415c9786c6f0 Gerrit-Change-Number: 15446 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Mar 2020 22:24:52 +0000 Gerrit-HasComments: Yes
