Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 )
Change subject: KUDU-2780: create thread for auto-rebalancing ...................................................................... Patch Set 23: (3 comments) http://gerrit.cloudera.org:8080/#/c/14177/20/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/14177/20/src/kudu/master/auto_rebalancer-test.cc@462 PS20, Line 462: ST_F(AutoRebalancerTest, NoRebalancin > Added another test case to make sure that the auto-rebalancer handles this Thank you very much for addressing this! http://gerrit.cloudera.org:8080/#/c/14177/23/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/14177/23/src/kudu/master/auto_rebalancer-test.cc@470 PS23, Line 470: 1 What if there were 4 tablets? Would the behavior change? Having 4 tablets would give the distribution a skew greater than 1 once additional tablet server is back in. With that we could get a definitive answer on whether the rebalancer does or does not attempt any replica movements based on unbalanced distribution but with unavailable servers out there. I think it's worth updating the number of tablets to be 4 to induce some greater imbalance after one extra tablet server is added. What do you think? http://gerrit.cloudera.org:8080/#/c/14177/23/src/kudu/master/auto_rebalancer-test.cc@524 PS23, Line 524: } Does it make sense to add a post-condition to verify the state of the system after the movements have been attempted but failed? E.g., at least make sure the rebalancer thread is still active and will do its job as expected once tablet servers are back? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/14177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifca25d1063c07047cf2123e6792b3c7395be20e4 Gerrit-Change-Number: 14177 Gerrit-PatchSet: 23 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 16 Mar 2020 19:23:11 +0000 Gerrit-HasComments: Yes
