Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 )
Change subject: KUDU-2780: create thread for auto-rebalancing ...................................................................... Patch Set 24: (3 comments) http://gerrit.cloudera.org:8080/#/c/14177/23/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/14177/23/src/kudu/master/auto_rebalancer-test.cc@524 PS23, Line 524: } > Added this! Hrm, seems like the new post-condition checks that the rebalancer will try to rebalance onto new servers, even if a bunch of servers are down, which seems kind of odd. I thought the rebalancer wouldn't do anything because the tservers hosting all the tablet replicas are presumed dead. Rather than adding new servers, I think the suggestion here was to restart the original tablet servers, wait for some moves to be scheduled, and maybe check that we didn't get any of those "could not perform replica move" errors. http://gerrit.cloudera.org:8080/#/c/14177/24/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/14177/24/src/kudu/master/auto_rebalancer-test.cc@528 PS24, Line 528: FLAGS_tserver_unresponsive_timeout_ms This is 2 minutes, which is pretty long to be sleeping in a test. How about instead of sleeping, just dropping this to something really low before adding the tserver. AFAICT the PresumedDead() checks are runtime checks and would honor this flag immediately. http://gerrit.cloudera.org:8080/#/c/14177/24/src/kudu/master/auto_rebalancer-test.cc@528 PS24, Line 528: FromSeconds nit: could use MonoDelta::FromMilliseconds() -- To view, visit http://gerrit.cloudera.org:8080/14177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifca25d1063c07047cf2123e6792b3c7395be20e4 Gerrit-Change-Number: 14177 Gerrit-PatchSet: 24 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 17 Mar 2020 06:23:18 +0000 Gerrit-HasComments: Yes
