Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 )
Change subject: KUDU-2780: create thread for auto-rebalancing ...................................................................... Patch Set 25: (4 comments) http://gerrit.cloudera.org:8080/#/c/14177/23/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/14177/23/src/kudu/master/auto_rebalancer-test.cc@524 PS23, Line 524: "could not perform replica move: Network error"); > Hrm, seems like the new post-condition checks that the rebalancer will try Ah, thanks for the clarification. Hopefully the updated test (and more specific error message) and the post-condition verification makes sense. http://gerrit.cloudera.org:8080/#/c/14177/24/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/14177/24/src/kudu/master/auto_rebalancer-test.cc@528 PS24, Line 528: onds(FLAGS_tserver_unresponsive_timeo > This is 2 minutes, which is pretty long to be sleeping in a test. How about Done http://gerrit.cloudera.org:8080/#/c/14177/24/src/kudu/master/auto_rebalancer-test.cc@528 PS24, Line 528: SleepFor(MonoDelta::FromMilliseconds(FLAGS_tserver_unresponsive_timeout_ms)); > warning: result of integer division used in a floating point context; possi Done http://gerrit.cloudera.org:8080/#/c/14177/24/src/kudu/master/auto_rebalancer-test.cc@528 PS24, Line 528: FromMillise > nit: could use MonoDelta::FromMilliseconds() Done -- To view, visit http://gerrit.cloudera.org:8080/14177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifca25d1063c07047cf2123e6792b3c7395be20e4 Gerrit-Change-Number: 14177 Gerrit-PatchSet: 25 Gerrit-Owner: Hannah Nguyen <hannah.ngu...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hannah Nguyen <hannah.ngu...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 17 Mar 2020 09:29:12 +0000 Gerrit-HasComments: Yes
