Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 )
Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15414/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15414/5//COMMIT_MSG@22 PS5, Line 22: even after running for longer > Can you check with the renewal lifetime and ensure that the Ranger plugin w Sure, will do just to double check. However, note that since checkTGTAndReloginFromKeytab relogin from keytab, IIUC it should be fine given 'if one doesn't renew the ticket before the ticket lifetime expires, you have to re-enter credentials or use the key from a _keytab_'. http://gerrit.cloudera.org:8080/#/c/15414/4/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java: http://gerrit.cloudera.org:8080/#/c/15414/4/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@78 PS4, Line 78: if (servicePrincipal.isEmpty() || keytab.isEmpty()) { : throw new KuduSubprocessException("Kudu > Maybe I'm misreading the comments there, but it seems like the suggestion w Right, that is why I added null check in the if comment previously. I didn't use preconditions since it will be more clear why we are falling here with the error message. -- To view, visit http://gerrit.cloudera.org:8080/15414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe043293ea9cc1c2f43a331603dc1e3b36ff6ae0 Gerrit-Change-Number: 15414 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 17 Mar 2020 02:17:58 +0000 Gerrit-HasComments: Yes
