Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 )
Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized ...................................................................... Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/15414/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15414/5//COMMIT_MSG@21 PS5, Line 21: Ranegr nit: Ranger http://gerrit.cloudera.org:8080/#/c/15414/5//COMMIT_MSG@22 PS5, Line 22: even after running for 15 mins Just to be sure, was this the ticket lifetime or the renewal lifetime? Some info: https://stackoverflow.com/questions/14682153/lifetime-of-kerberos-tickets http://gerrit.cloudera.org:8080/#/c/15414/4/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java: http://gerrit.cloudera.org:8080/#/c/15414/4/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@78 PS4, Line 78: if (servicePrincipal.isEmpty() || keytab.isEmpty()) { : throw new KuduSubprocessException("Kudu > Yeah, it is intentional in SubprocessConfiguration. Removed the check even Yeah, you're right that it doesn't hurt given the condition is so simple. But ideally, assumptions and invariants about inputs are made obvious in the code. As code evolves, the assumptions and invariants may change and may become difficult to track. Putting them in code via Preconditions or D/CHECKs makes that less painful, since they signal to readers of what they should expect, vs having to second guess what the possible inputs are. -- To view, visit http://gerrit.cloudera.org:8080/15414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe043293ea9cc1c2f43a331603dc1e3b36ff6ae0 Gerrit-Change-Number: 15414 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 17 Mar 2020 00:23:11 +0000 Gerrit-HasComments: Yes
