Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 )
Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15414/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15414/5//COMMIT_MSG@22 PS5, Line 22: even after running for longer > Sure, will do just to double check. However, note that since checkTGTAndRel Thanks, my point is that we should ensure that Ranger will be able to successfully re-login using the keytab. IIUC the manual test here only tested getting a new ticket, which tests the "check TGT" part of checkTGTAndReloginFromKeytab, but I don't think it tests the "relogin" part. http://gerrit.cloudera.org:8080/#/c/15414/4/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java: http://gerrit.cloudera.org:8080/#/c/15414/4/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/authorization/RangerKuduAuthorizer.java@78 PS4, Line 78: if (servicePrincipal.isEmpty() || keytab.isEmpty()) { : throw new KuduSubprocessException("Kudu > Right, that is why I added null check in the if comment previously. I didn' I see. I think my confusion stems from my assumption was that Grant's suggestion also entailed updating the SubprocessConfiguration to set these to null by default, rather than empty strings. Otherwise these are never null. -- To view, visit http://gerrit.cloudera.org:8080/15414 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe043293ea9cc1c2f43a331603dc1e3b36ff6ae0 Gerrit-Change-Number: 15414 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 17 Mar 2020 02:44:56 +0000 Gerrit-HasComments: Yes
