Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 )
Change subject: [ranger] parameterize the Java binary path for the subprocess ...................................................................... Patch Set 7: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc@145 PS1, Line 145: > Yeah but we BaseName argv[0], which seems to confuse things. Maybe this is I haven't found anything definitive here, but IIUC, the `program_` member stored in Subprocess is used to determine what file the process will start executing, and the argv (which has been Basename()d) is what is passed as the arguments to that process's main(). I took a quick look at initdb.c https://doxygen.postgresql.org/initdb_8c_source.html but didn't look hard enough to determine what it actually does with argv[0]. Looking at this https://doxygen.postgresql.org/common_2exec_8c.html#a093d65fb706d3126673c016743026386, maybe setting cwd in Subprocess might help your case Attila. As far as `java` goes, I haven't been able to find what it does either. That said, I'd be surprised if it did anything fancy with argv[0]. -- To view, visit http://gerrit.cloudera.org:8080/15415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f23a4e96ec5fd29de0e6d598d4400f5ac92366 Gerrit-Change-Number: 15415 Gerrit-PatchSet: 7 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 18 Mar 2020 01:17:38 +0000 Gerrit-HasComments: Yes
