Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 )
Change subject: [ranger] parameterize the Java binary path for the subprocess ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/15415/6/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15415/6/src/kudu/ranger/ranger_client.cc@129 PS6, Line 129: Env::Default()->FileExists(FLAGS_ranger_java_path) How does this check bode with the comment on the ranger_java_path flag claiming that in case on non-absolute path it will be evaluated using the Kudu's user's PATH? As far as I can see, Env::Default()->FileExists() checks for the presence of that path on the filesystem as is, no? -- To view, visit http://gerrit.cloudera.org:8080/15415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f23a4e96ec5fd29de0e6d598d4400f5ac92366 Gerrit-Change-Number: 15415 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 15 Mar 2020 18:56:56 +0000 Gerrit-HasComments: Yes
