Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 )
Change subject: [ranger] parameterize the Java binary path for the subprocess ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15415/1/src/kudu/ranger/ranger_client.cc@145 PS1, Line 145: > the Java binary may be a different version that the user wants to use that Since we use execvp() call to start the subprocess, based on man for execvp(): "The execlp(), execvp(), and execvpe() functions duplicate the actions of the shell in searching for an executable file if the specified filename does not contain a slash (/) character. The file is sought in the colon-separated list of directory pathnames specified in the PATH environment variable. If this variable isn't defined, the path list defaults to the current directory followed by the list of directories returned by confstr(_CS_PATH). (This confstr(3) call typically returns the value "/bin:/usr/bin".) If the specified filename includes a slash character, then PATH is ignored and the file at the specified pathname is executed." IIUC, the full path set by the flag should be honored. http://gerrit.cloudera.org:8080/#/c/15415/6/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15415/6/src/kudu/ranger/ranger_client.cc@129 PS6, Line 129: rst, check the specified path. > How does this check bode with the comment on the ranger_java_path flag clai Hmm, good catch. Updated. -- To view, visit http://gerrit.cloudera.org:8080/15415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8f23a4e96ec5fd29de0e6d598d4400f5ac92366 Gerrit-Change-Number: 15415 Gerrit-PatchSet: 7 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 18 Mar 2020 00:08:37 +0000 Gerrit-HasComments: Yes
