Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 )
Change subject: KUDU-3079 Add MiniPostgres ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/15374/6/src/kudu/ranger/mini_postgres.cc File src/kudu/ranger/mini_postgres.cc: http://gerrit.cloudera.org:8080/#/c/15374/6/src/kudu/ranger/mini_postgres.cc@102 PS6, Line 102: : > Done I was and am worried that this would be flaky. If we run this from multiple tests concurrently, could multiple processes attempt to bond to the same port? http://gerrit.cloudera.org:8080/#/c/15374/8/src/kudu/ranger/mini_postgres.cc File src/kudu/ranger/mini_postgres.cc: http://gerrit.cloudera.org:8080/#/c/15374/8/src/kudu/ranger/mini_postgres.cc@81 PS8, Line 81: // need to prepend $PATH with bin_dir_ as initdb uses argv[0] to determine Nit: capitalize and make a complete sentence? http://gerrit.cloudera.org:8080/#/c/15374/8/src/kudu/ranger/mini_postgres.cc@143 PS8, Line 143: // The file template is copied from postgresql.conf generated by initdb. We Nit: would be nice to read this file and just add a new line for the port. Is that possible? -- To view, visit http://gerrit.cloudera.org:8080/15374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba40126aa60e0ecbc5ae10cc1328493194c345bc Gerrit-Change-Number: 15374 Gerrit-PatchSet: 8 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 19 Mar 2020 16:41:51 +0000 Gerrit-HasComments: Yes
