Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 )
Change subject: WIP: iwyu: standardize on libc++ ...................................................................... Patch Set 2: (3 comments) Thanks for addressing this issue, Adar. http://gerrit.cloudera.org:8080/#/c/15492/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15492/2//COMMIT_MSG@35 PS2, Line 35: Seems : like some codebases are comfortable including <new> for such usage; should : we follow suit? > Another option is to patch IWYU to forcefully omit this inclusion. Patching IWYU to omit <new> would be better. http://gerrit.cloudera.org:8080/#/c/15492/2/build-support/iwyu.py File build-support/iwyu.py: http://gerrit.cloudera.org:8080/#/c/15492/2/build-support/iwyu.py@58 PS2, Line 58: _MUTED_FILES = set([]) Removed files no longer need to be muted? http://gerrit.cloudera.org:8080/#/c/15492/2/build-support/iwyu/mappings/system-linux.imp File build-support/iwyu/mappings/system-linux.imp: http://gerrit.cloudera.org:8080/#/c/15492/2/build-support/iwyu/mappings/system-linux.imp@41 PS2, Line 41: <time.h> <ctime> instead? -- To view, visit http://gerrit.cloudera.org:8080/15492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic807745271642b3d5d80ea0ad9bc413bdb0e34b5 Gerrit-Change-Number: 15492 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 19 Mar 2020 17:15:36 +0000 Gerrit-HasComments: Yes
