Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 )
Change subject: iwyu: standardize on libc++ ...................................................................... Patch Set 4: (3 comments) New IWYU run on all files: https://pastebin.com/Mcyd3pfF http://gerrit.cloudera.org:8080/#/c/15492/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15492/2//COMMIT_MSG@35 PS2, Line 35: : : > I'm OK with either approach here. Probably, not including the <new> heade I found the underlying bug in IWYU and fixed it. This patch includes that fix as a new TP patch for IWYU. http://gerrit.cloudera.org:8080/#/c/15492/2/build-support/iwyu.py File build-support/iwyu.py: http://gerrit.cloudera.org:8080/#/c/15492/2/build-support/iwyu.py@58 PS2, Line 58: _FIX_INCLUDES_STYLE_FL > Removed files no longer need to be muted? I wasn't sure yet if this should be a permanent change; I just wanted IWYU to run on all files. But now I agree. Done. http://gerrit.cloudera.org:8080/#/c/15492/2/build-support/iwyu/mappings/system-linux.imp File build-support/iwyu/mappings/system-linux.imp: http://gerrit.cloudera.org:8080/#/c/15492/2/build-support/iwyu/mappings/system-linux.imp@41 PS2, Line 41: <time.h> > It might be tricky with IWYU if doing so, but it might work, indeed. Last I don't think <ctime> makes sense here; we're talking about a pure C struct whose definition we want to draw from the appropriate C header. IWYU has a built-in mapping that looks like this: { include: ["<time.h>", public, "<ctime>", public] }, That'll make <ctime> a usable substitute for <time.h> (i.e. IWYU won't ask you to change it to <time.h>). But since <time.h> is defined as public, we can't define it as private and force IWYU to always substitute. That said, clang-tidy's modernize-deprecated-headers check can handle this for us, we just haven't enabled it. -- To view, visit http://gerrit.cloudera.org:8080/15492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic807745271642b3d5d80ea0ad9bc413bdb0e34b5 Gerrit-Change-Number: 15492 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 23 Mar 2020 22:12:05 +0000 Gerrit-HasComments: Yes
