Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 )
Change subject: WIP: iwyu: standardize on libc++ ...................................................................... Patch Set 2: (2 comments) Thank you very much for doing this! http://gerrit.cloudera.org:8080/#/c/15492/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15492/2//COMMIT_MSG@35 PS2, Line 35: Seems : like some codebases are comfortable including <new> for such usage; should : we follow suit? > Patching IWYU to omit <new> would be better. I'm OK with either approach here. Probably, not including the <new> header could save a bit of compilation time, but I don't think that would be much. As per https://en.cppreference.com/w/cpp/memory/new/operator_new , signatures like 1-4 should not require inclusion of the <new> header: The versions (1-4) are implicitly declared in each translation unit even if the <new> header is not included. Patching iwyu to avoid the recommendation of including the <new> header seems safe, even if using some coarse blanket-style rule that ignores other signatures (5-22). There should be a compiler error if not including required <new> as required anyways. http://gerrit.cloudera.org:8080/#/c/15492/2/build-support/iwyu/mappings/system-linux.imp File build-support/iwyu/mappings/system-linux.imp: http://gerrit.cloudera.org:8080/#/c/15492/2/build-support/iwyu/mappings/system-linux.imp@41 PS2, Line 41: <time.h> > <ctime> instead? It might be tricky with IWYU if doing so, but it might work, indeed. Last time I tried that with 'clockid_t' (se line 37), it didn't work. -- To view, visit http://gerrit.cloudera.org:8080/15492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic807745271642b3d5d80ea0ad9bc413bdb0e34b5 Gerrit-Change-Number: 15492 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 19 Mar 2020 18:38:48 +0000 Gerrit-HasComments: Yes
