Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 )
Change subject: KUDU-2780: create thread for auto-rebalancing ...................................................................... Patch Set 26: Code-Review+2 (2 comments) Looks good enough to me. Maybe Andrew has more feedback. http://gerrit.cloudera.org:8080/#/c/14177/23/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/14177/23/src/kudu/master/auto_rebalancer-test.cc@524 PS23, Line 524: "scheduled replica move failed to complete: Network error"); > Indeed, the idea was as Andrew described. Thank you for addressing this -- Ah, sure, it should read '... now it makes more sense to me' :) http://gerrit.cloudera.org:8080/#/c/14177/25/src/kudu/master/master_runner.cc File src/kudu/master/master_runner.cc: http://gerrit.cloudera.org:8080/#/c/14177/25/src/kudu/master/master_runner.cc@60 PS25, Line 60: void SetMasterFlagDefaults() { : // Reset some default values before parsing gflags. : CHECK_NE("", google::SetCommandLineOptionWithMode("rpc_bind_addresses", : strings::Substitute( : "0.0.0.0:$0", : Master::kDefaultPort).c_str(), : google::FlagSettingMode::SET_FLAGS_DEFAULT)); : CHECK_NE("", google::SetCommandLineOptionWithMode("webserver_port", : std::to_string( : Master::kDefaultWebPort).c_str(), : > Created a validator in master/catalog_manager.cc where the flag is defined, Thank you for addressing this! Keeping consistency checks for flags where we expect it definitely helps. -- To view, visit http://gerrit.cloudera.org:8080/14177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifca25d1063c07047cf2123e6792b3c7395be20e4 Gerrit-Change-Number: 14177 Gerrit-PatchSet: 26 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 20 Mar 2020 06:14:40 +0000 Gerrit-HasComments: Yes
