Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15525 )

Change subject: [ranger] allow subprocess to log to a file
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15525/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15525/1//COMMIT_MSG@11
PS1, Line 11: debugLog' to
            : determine if debug level logging should be enabled for the 
subprocess.
Is there anything meaningful in the debug logs that we need?


http://gerrit.cloudera.org:8080/#/c/15525/1/java/kudu-subprocess/src/main/resources/log4j2.properties
File java/kudu-subprocess/src/main/resources/log4j2.properties:

http://gerrit.cloudera.org:8080/#/c/15525/1/java/kudu-subprocess/src/main/resources/log4j2.properties@20
PS1, Line 20: property.filename = logs
            : appenders = console, file
            :
            : # Declare two appenders, named console and file. And configure the
            : # appenders to write log messages to the console and a file 
(logs/subprocess.log).
            : appender.console.type = Console
            : appender.console.name = STDOUT
            : appender.console.layout.type = PatternLayout
            : appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss.SSS} [%p 
- %t] (%F:%L) %m%n
            :
            : appender.file.type = File
            : appender.file.name = LOGFILE
            : appender.file.fileName= ${filename}/subprocess.log
            : appender.file.layout.type=PatternLayout
            : appender.file.layout.pattern= %d{yyyy-MM-dd HH:mm:ss.SSS} [%p - 
%t] (%F:%L) %m%n
            :
            : loggers = file
            : logger.file.name = org.apache
            : logger.file.level = info
            : logger.file.appenderRefs = file
            : logger.file.appenderRef.file.ref = LOGFILE
Should we use a rolling log appender to programmatically define the log 
locations? We do something similar for the server logs such that every time we 
restart, we log to a new file.



--
To view, visit http://gerrit.cloudera.org:8080/15525
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e0c64a05ff936044807df7efc698569f494f0e7
Gerrit-Change-Number: 15525
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 23 Mar 2020 07:34:41 +0000
Gerrit-HasComments: Yes

Reply via email to