Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15525 )
Change subject: [ranger] allow subprocess to log to a file ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15525/1/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerSubprocessMain.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerSubprocessMain.java: http://gerrit.cloudera.org:8080/#/c/15525/1/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerSubprocessMain.java@41 PS1, Line 41: if (conf.getDebugLogging()) { > If we decide to go this route could we allow configuring the path to the lo Sorry, I continued down this path without looking over the comments here. Moved over to: https://gerrit.cloudera.org/c/15627/ Wouldn't this mean users or vendors would have to write their on log4j properties file and colocate it with the master? I guess that's not uncommon for vendors, but based on our server-side logging, and given trickiness around stdout, I'm inclined to not give users a whole lot of flexibility in terms of dictating what logs and what doesn't. I agree that the custom code (even in the new patch) isn't pretty. Curious how strongly you feel about this. -- To view, visit http://gerrit.cloudera.org:8080/15525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e0c64a05ff936044807df7efc698569f494f0e7 Gerrit-Change-Number: 15525 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 01 Apr 2020 22:05:07 +0000 Gerrit-HasComments: Yes
