Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15602 )
Change subject: tserver: add support for returning scan result in columnar layout ...................................................................... Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_server-test.cc@2543 PS2, Line 2543: TEST_F(TabletServerTest, TestColumnarScan) { nit: Consider extending this to return multiple batches to exercise the continuing scan case? http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_service.cc@743 PS2, Line 743: : virtual int SerializeRowBlock(const RowBlock& row_block, : const Schema* client_projection_schema) = 0; : virtual size_t ResponseSize() const = 0; : virtual void SetupResponse(rpc::RpcContext* context, ScanResponsePB* resp) = 0; nit: doc these? http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_service.cc@791 PS2, Line 791: private: nit: add a 'done_' here too? http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_service.cc@803 PS2, Line 803: } nit: Can we also validate the PAD_UNIX_MICROS flag here? http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_service.cc@913 PS2, Line 913: return Status::OK(); nit: move this down so we have an explicit return? http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_service.cc@2214 PS2, Line 2214: TabletServiceImpl Should we also update TabletServiceAdminImpl? http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_service.cc@2731 PS2, Line 2731: // Set the row format flags on the ScanResultCollector. : s = result_collector->InitSerializer(scanner->row_format_flags()); : if (!s.ok()) { : *error_code = TabletServerErrorPB::INVALID_SCAN_SPEC; : return s; : } Should we move this down under the ScopedUnregisterScanner? If this fails, chances are, we won't be able to use the scanner in the future either. http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tserver.proto@390 PS2, Line 390: message ColumnarRowBlockPB { nit: Should this be in wire_protocol.proto alongside RowwiseRowBlockPB? http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tserver.proto@391 PS2, Line 391: message Column { nit: Can you note the units here are sidecar indices? http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tserver.proto@394 PS2, Line 394: // Any data referred to by strings. nit: Maybe also note the relation between this and 'data_sidecar' re offsets? -- To view, visit http://gerrit.cloudera.org:8080/15602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib99faa27554ec228492f096bb8760c883e44660d Gerrit-Change-Number: 15602 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 30 Mar 2020 23:05:12 +0000 Gerrit-HasComments: Yes
