Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15602 )
Change subject: tserver: add support for returning scan result in columnar layout ...................................................................... Patch Set 4: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_server-test.cc@2543 PS2, Line 2543: const int kNumRows = 100; > I'm going to cover this in the test that uses the client -- is that OK? Yep, sgtm http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_service.cc@803 PS2, Line 803: fas > the above checks that no flags other than COLUMNAR_LAYOUT have been set Ack http://gerrit.cloudera.org:8080/#/c/15602/2/src/kudu/tserver/tablet_service.cc@2214 PS2, Line 2214: > I don't think so, since this feature is only used for calls in the TabletSe Yeah good point, these are really features of the service impl, rather than the server itself. We should probably remove the ones that are not currently being depended on. -- To view, visit http://gerrit.cloudera.org:8080/15602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib99faa27554ec228492f096bb8760c883e44660d Gerrit-Change-Number: 15602 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 31 Mar 2020 20:08:49 +0000 Gerrit-HasComments: Yes
