Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15602 )
Change subject: tserver: add support for returning scan result in columnar layout ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15602/5/src/kudu/common/wire_protocol.proto File src/kudu/common/wire_protocol.proto: http://gerrit.cloudera.org:8080/#/c/15602/5/src/kudu/common/wire_protocol.proto@170 PS5, Line 170: optional int64 num_rows = 2; This isn't symmetrical with the RowwiseRowBlockPB num_rows that returns an int32. Should it be? -- To view, visit http://gerrit.cloudera.org:8080/15602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib99faa27554ec228492f096bb8760c883e44660d Gerrit-Change-Number: 15602 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 02 Apr 2020 16:26:30 +0000 Gerrit-HasComments: Yes
