Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15679 )
Change subject: columnar_serialization: avoid preallocating 8MB per column ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15679/1/src/kudu/common/columnar_serialization.h File src/kudu/common/columnar_serialization.h: http://gerrit.cloudera.org:8080/#/c/15679/1/src/kudu/common/columnar_serialization.h@38 PS1, Line 38: batch_size_bytes Does it make sense to document at least this parameter? http://gerrit.cloudera.org:8080/#/c/15679/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/15679/1/src/kudu/tserver/tablet_service.cc@925 PS1, Line 925: batch_size_bytes Where does it come from? Should it be somehow passed in as a parameter of the enclosing method or be a member field? -- To view, visit http://gerrit.cloudera.org:8080/15679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b7ff78547792acbd975a606a02ec388dba3a8e8 Gerrit-Change-Number: 15679 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 08 Apr 2020 05:07:38 +0000 Gerrit-HasComments: Yes
