Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15679 )
Change subject: columnar_serialization: avoid preallocating 8MB per column ...................................................................... Patch Set 4: Code-Review+2 (1 comment) It seems I'm late with the review, but anyways :) Feel free to ignore the nit (especially given the fact this patch is already committed). http://gerrit.cloudera.org:8080/#/c/15679/3/src/kudu/common/columnar_serialization.h File src/kudu/common/columnar_serialization.h: http://gerrit.cloudera.org:8080/#/c/15679/3/src/kudu/common/columnar_serialization.h@44 PS3, Line 44: is nit: extra 'is' -- To view, visit http://gerrit.cloudera.org:8080/15679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b7ff78547792acbd975a606a02ec388dba3a8e8 Gerrit-Change-Number: 15679 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 16 Apr 2020 00:41:14 +0000 Gerrit-HasComments: Yes
