Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15679 )
Change subject: columnar_serialization: avoid preallocating 8MB per column ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15679/1/src/kudu/common/columnar_serialization.h File src/kudu/common/columnar_serialization.h: http://gerrit.cloudera.org:8080/#/c/15679/1/src/kudu/common/columnar_serialization.h@38 PS1, Line 38: batch_size_bytes > Does it make sense to document at least this parameter? +1 Or rename this to expected_max_batch_size_bytes or something. Without reading the implementation, this can be a bit confusing, given we're not initializing the batch with any data, but we're giving it a size. -- To view, visit http://gerrit.cloudera.org:8080/15679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b7ff78547792acbd975a606a02ec388dba3a8e8 Gerrit-Change-Number: 15679 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 13 Apr 2020 07:12:45 +0000 Gerrit-HasComments: Yes
