Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 )
Change subject: KUDU-3078 Add Ranger tests to master_authz-itest ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/15681/13/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/15681/13/src/kudu/integration-tests/master_authz-itest.cc@326 PS13, Line 326: opts.num_masters = 1; > why is the default overridden here? ah if it's the default, we can remove it http://gerrit.cloudera.org:8080/#/c/15681/14/src/kudu/integration-tests/ts_sentry-itest.cc File src/kudu/integration-tests/ts_sentry-itest.cc: http://gerrit.cloudera.org:8080/#/c/15681/14/src/kudu/integration-tests/ts_sentry-itest.cc@356 PS14, Line 356: class TSAuthzITest : public ExternalMiniClusterITestBase { can you make this look more like the master test with an enum? or separate this out into the next patch where you parameterize for ranger? -- To view, visit http://gerrit.cloudera.org:8080/15681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25dc67516cd61f0624914989f8db4c4f94d7e3bf Gerrit-Change-Number: 15681 Gerrit-PatchSet: 14 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 09 Apr 2020 17:35:11 +0000 Gerrit-HasComments: Yes
