Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 )
Change subject: KUDU-3078 Add Ranger tests to master_authz-itest ...................................................................... Patch Set 15: (5 comments) http://gerrit.cloudera.org:8080/#/c/15681/13/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/15681/13/src/kudu/integration-tests/master_authz-itest.cc@326 PS13, Line 326: // Always enable Kerberos, as Sentry/Ranger deployments do not make sense > ah if it's the default, we can remove it Done http://gerrit.cloudera.org:8080/#/c/15681/13/src/kudu/integration-tests/master_authz-itest.cc@515 PS13, Line 515: policy.items.emplace_back(Policy > Checking a bit, it seems it is IsCreateTableDone() requiring METADATA on t Done http://gerrit.cloudera.org:8080/#/c/15681/13/src/kudu/integration-tests/master_authz-itest.cc@554 PS13, Line 554: policy_new_table.tables.emplace_back("*"); > Same here. Done http://gerrit.cloudera.org:8080/#/c/15681/14/src/kudu/integration-tests/ts_sentry-itest.cc File src/kudu/integration-tests/ts_sentry-itest.cc: http://gerrit.cloudera.org:8080/#/c/15681/14/src/kudu/integration-tests/ts_sentry-itest.cc@356 PS14, Line 356: public: > can you make this look more like the master test with an enum? or separate changed it to TSSentryITest without the template if that's what you meant by separating it out. Can't really remove it from here due to the rest of the refactor. http://gerrit.cloudera.org:8080/#/c/15681/14/src/kudu/master/ranger_authz_provider.cc File src/kudu/master/ranger_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/15681/14/src/kudu/master/ranger_authz_provider.cc@194 PS14, Line 194: atus RangerAuthzProvider::FillTablePrivilegePB(const string& table_name, : const string& user, : const SchemaPB& schema_pb, : TablePrivilegePB* pb) { : DCHECK(pb); : DCHECK(pb->has_table_id()); : bool authorized; : if (IsTrustedUser(user) || > This should belong to https://gerrit.cloudera.org/c/15696/? Done -- To view, visit http://gerrit.cloudera.org:8080/15681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25dc67516cd61f0624914989f8db4c4f94d7e3bf Gerrit-Change-Number: 15681 Gerrit-PatchSet: 15 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 09 Apr 2020 21:00:30 +0000 Gerrit-HasComments: Yes
