Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 )
Change subject: KUDU-3078 Add Ranger tests to master_authz-itest ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/15681/14/src/kudu/integration-tests/ts_sentry-itest.cc File src/kudu/integration-tests/ts_sentry-itest.cc: http://gerrit.cloudera.org:8080/#/c/15681/14/src/kudu/integration-tests/ts_sentry-itest.cc@356 PS14, Line 356: public: > changed it to TSSentryITest without the template if that's what you meant b That's a small part of it, but my main gripe the (IMO) odd semantics around cluster setup vs harness code -- how it relies on injecting test methods via this lambda instead of clarifying the boundary of what belongs in test code and what belongs in harness code. We do this in master_authz-itest with the GetClusterOpts() and SetUpCluster(HarnessEnum) methods. -- To view, visit http://gerrit.cloudera.org:8080/15681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25dc67516cd61f0624914989f8db4c4f94d7e3bf Gerrit-Change-Number: 15681 Gerrit-PatchSet: 15 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 09 Apr 2020 21:07:42 +0000 Gerrit-HasComments: Yes
