Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15678 )
Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/15678/1/src/kudu/common/columnar_serialization.h File src/kudu/common/columnar_serialization.h: http://gerrit.cloudera.org:8080/#/c/15678/1/src/kudu/common/columnar_serialization.h@36 PS1, Line 36: ColumnarSerializedBatch(const Schema& scan_schema, : const Schema& client_schema); nit: doc how the schemas are used? By its naming and by reading the rest of the class declaration scan_schema is pretty clear; client_schema less so. http://gerrit.cloudera.org:8080/#/c/15678/1/src/kudu/common/columnar_serialization.h@46 PS1, Line 46: scan_schema_col_idx nit: we're somewhat far removed from scans and scanners at this point. Maybe rename this to rowblock_schema and rowblock_schema_col_idx? -- To view, visit http://gerrit.cloudera.org:8080/15678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b683c7d6d6fe1026ee06c8b5ebfe2a5f1ee6cb1 Gerrit-Change-Number: 15678 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 13 Apr 2020 07:04:50 +0000 Gerrit-HasComments: Yes
