Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15678 )
Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization ...................................................................... Patch Set 3: Verified+1 (2 comments) Test failure unrelated http://gerrit.cloudera.org:8080/#/c/15678/1/src/kudu/common/columnar_serialization.h File src/kudu/common/columnar_serialization.h: http://gerrit.cloudera.org:8080/#/c/15678/1/src/kudu/common/columnar_serialization.h@36 PS1, Line 36: // 'rowblock_schema': the schema of the RowBlocks that will be passed to : // AddRowBlock(). > nit: doc how the schemas are used? By its naming and by reading the rest of Done http://gerrit.cloudera.org:8080/#/c/15678/1/src/kudu/common/columnar_serialization.h@46 PS1, Line 46: dRowBlock(const Row > nit: we're somewhat far removed from scans and scanners at this point. Mayb Done -- To view, visit http://gerrit.cloudera.org:8080/15678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b683c7d6d6fe1026ee06c8b5ebfe2a5f1ee6cb1 Gerrit-Change-Number: 15678 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 15 Apr 2020 23:59:36 +0000 Gerrit-HasComments: Yes
