Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15678 )
Change subject: Avoid calling Schema::find_column() once per RowBlock in columnar serialization ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15678/2/src/kudu/common/columnar_serialization.cc File src/kudu/common/columnar_serialization.cc: http://gerrit.cloudera.org:8080/#/c/15678/2/src/kudu/common/columnar_serialization.cc@587 PS2, Line 587: scan_schema nit: update here too -- To view, visit http://gerrit.cloudera.org:8080/15678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b683c7d6d6fe1026ee06c8b5ebfe2a5f1ee6cb1 Gerrit-Change-Number: 15678 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 15 Apr 2020 22:26:16 +0000 Gerrit-HasComments: Yes
