Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15828 )
Change subject: [master-test] added GetTableSchema() microbenchmarks ...................................................................... Patch Set 3: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/15828/1/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/15828/1/src/kudu/master/master-test.cc@1139 PS1, Line 1139: const auto errors = accumulate(error_counters.begin(), error_counters.end(), 0UL); : if (errors != 0) { : FAIL() << Substitute("detected $0 errors", errors); : } : : const auto total = accumulate(call_counters.begin(), call_counters.end(), 0UL); : L > Moved setting supports_authz_ into the constructor. Ack http://gerrit.cloudera.org:8080/#/c/15828/3/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/15828/3/src/kudu/master/master-test.cc@1123 PS3, Line 1123: if (resp.has_error()) { nit: consider logging the error too. http://gerrit.cloudera.org:8080/#/c/15828/3/src/kudu/master/master-test.cc@1187 PS3, Line 1187: ++error_counters[idx]; nit: same here -- To view, visit http://gerrit.cloudera.org:8080/15828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f3d4fe1df426d50bd465c8ca7bbfb6924bffe9 Gerrit-Change-Number: 15828 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 30 Apr 2020 22:14:32 +0000 Gerrit-HasComments: Yes
