Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15828 )

Change subject: [master-test] added GetTableSchema() microbenchmarks
......................................................................


Patch Set 4: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15828/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15828/4//COMMIT_MSG@13
PS4, Line 13: Results for a RELEASE build:
Curious whether these numbers are at all close to the numbers in the cluster 
you saw. I also wonder whether the cluster was getting hit with many alter 
table requests to drop/add range partitions. Would that lead to a large number 
of OpenTable() calls, in the same way that altering schemas does?


http://gerrit.cloudera.org:8080/#/c/15828/4//COMMIT_MSG@14
PS4, Line 14:   authz disabled: completed 208055 GetTableSchema RPC requests in 
5.000s
nit: at some point, we'll probably want to track requests/sec so we can modify 
the timings without a significant change in values.



--
To view, visit http://gerrit.cloudera.org:8080/15828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1f3d4fe1df426d50bd465c8ca7bbfb6924bffe9
Gerrit-Change-Number: 15828
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Fri, 01 May 2020 18:28:59 +0000
Gerrit-HasComments: Yes

Reply via email to