Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15828 )
Change subject: [master-test] added GetTableSchema() microbenchmarks ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/15828/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15828/4//COMMIT_MSG@13 PS4, Line 13: Results for a RELEASE build: > Curious whether these numbers are at all close to the numbers in the cluste The numbers were significantly lower than these numbers (the information is based on RPC request counting metrics) in the cluster I looked at. As for the amount of AlterTable() calls, the number of those calls was negligible compared with the number of GetTableSchema()/GetTableLocations() requests (i.e. 1 request/minute for AlterTable vs 2K requests/second for GetTableSchema()). At least that's what I saw in the recently collected diagnostics logs. I'll check the very first one, though. Does this answer your question? http://gerrit.cloudera.org:8080/#/c/15828/4//COMMIT_MSG@14 PS4, Line 14: authz disabled: completed 208055 GetTableSchema RPC requests in 5.000s > nit: at some point, we'll probably want to track requests/sec so we can mod This is a good idea. I think it's easier to go with that, and start right away. I'll update the patch accordingly. -- To view, visit http://gerrit.cloudera.org:8080/15828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f3d4fe1df426d50bd465c8ca7bbfb6924bffe9 Gerrit-Change-Number: 15828 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 01 May 2020 20:54:12 +0000 Gerrit-HasComments: Yes
