Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 )
Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc@864 PS7, Line 864: // CREATE TABLE t (k INT, f INT), > nit: there's no "f" column (any more?) Sorry, I committed change to wrong patch. Just fixed it. Please review the code again. http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc@877 PS7, Line 877: vector<PartitionSchema::HashBucketSchema> hash_buckets1; : hash_buckets1.emplace_back(PartitionSchema::HashBucketSchema{{ColumnId(0)}, 2, 0}); : vector<PartitionSchema::HashBucketSchema> hash_buckets2; : hash_buckets2.emplace_back(PartitionSchema::HashBucketSchema{{ColumnId(0)}, 3, 0}); : vector<PartitionSchema::HashBucketSchema> hash_buckets3; > Thanks! Did you mean to push review feedback from this patch into the part Sorry, I committed change to wrong patch. Just fixed it. Please review the code again. -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 8 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Tue, 05 May 2020 18:51:25 +0000 Gerrit-HasComments: Yes
