Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 )
Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@405 PS3, Line 405: RETURN_NOT_OK(SplitRangeBounds(schema, std::m > nit: while I appreciate the hints, I think it'd be much more helpful in und Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@409 PS3, Line 409: // We have to simultaneously iterate through range bounds vector : // and hash schema per range vector (range_hash_buckets). : // range_hash_buckets.szie() == bounds.size() : for (int i = 0; i < bounds.size(); i++) { : > nit: may be slightly less error-prone to iterate via an index and just refe Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@420 PS3, Line 420: vector<Partition> new_partitions; : : for (const Partition& base_partition : all_hash_partitions) { > nit: maybe "For every hash partition created above, replace it with multipl Done http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@431 PS3, Line 431: } > Shouldn't we only swap after we've created all of the range-hash buckets? O Done -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 6 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 24 Apr 2020 05:34:17 +0000 Gerrit-HasComments: Yes
