Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 )
Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition. ...................................................................... Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/15758/3/src/kudu/common/partition.cc@368 PS3, Line 368: > Ack Here we compute hash partitions for "outer" hash http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@357 PS7, Line 357: const RangeBounds& range_bounds, : const boost::optional<RangeHashBuckets>& range_hash_buckets, : const Schema& schema, : vector<Partition>* partitions) const { > nit: fix spacing Done http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@369 PS7, Line 369: // Step 1 > nit: drop this if there's no step 2? Done http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@411 PS7, Line 411: // range_hash_buckets.szie() == bounds.size() > nit: you could consider bringing that DCHECK from L363 down here with a DCH Done http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@412 PS7, Line 412: int > nit: auto ? Done http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@414 PS7, Line 414: vector<HashBucketSchema> > nit: maybe, use auto? Done http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@429 PS7, Line 429: new_partitions.push_back(partition); > nit: does it make sense to use emplace_back(std::move(partion)) here? Done http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@432 PS7, Line 432: all_hash_partitions.swap(new_partitions); > Is std::move() any better here or that's the same? Done http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition.cc@432 PS7, Line 432: all_hash_partitions.swap(new_partitions); > Maybe i'm missing something, but I don't think this addresses my concern fr That's correct. Multiple hash schemas produce combination. https://kudu.apache.org/docs/schema_design.html#hash-hash-partitioning-example -- To view, visit http://gerrit.cloudera.org:8080/15758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011 Gerrit-Change-Number: 15758 Gerrit-PatchSet: 7 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Sun, 03 May 2020 20:13:17 +0000 Gerrit-HasComments: Yes
