Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h File src/kudu/util/logging.h: http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h@a229 PS1, Line 229: : : > Just curious: why it was necessary to remove this? The issue with wrong se This was removed from glog all together: https://github.com/google/glog/commit/dd19fb2466fb5c90369eb1387a9ba0689e7d0387 And the usage was removed in the LOG_EVERY_N implementation (Which this KLOG_EVERY_N copies). That commit explains why it is safe: https://github.com/google/glog/commit/8b3023f7e4ca46e0ecf5f660dd7340c79139bc34#diff-c6aaa6ad4cf2cf8741c91a15c62907ca -- To view, visit http://gerrit.cloudera.org:8080/15924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413 Gerrit-Change-Number: 15924 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 15 May 2020 19:26:10 +0000 Gerrit-HasComments: Yes
