Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h File src/kudu/util/logging.h: http://gerrit.cloudera.org:8080/#/c/15924/1/src/kudu/util/logging.h@a229 PS1, Line 229: : : > This was removed from glog all together: https://github.com/google/glog/com Well, in this file at lines 253, 257, etc. this macro is still in use. Does it mean it's necessary to remove those usages as well? Or I'm missing something? -- To view, visit http://gerrit.cloudera.org:8080/15924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413 Gerrit-Change-Number: 15924 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 15 May 2020 23:18:59 +0000 Gerrit-HasComments: Yes
