Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15924 )
Change subject: KUDU-2817: Upgrade glog to 0.4.0 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15924/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15924/1//COMMIT_MSG@15 PS1, Line 15: I needed to adjust the remaining patch to apply and fix some usage of : the CHECK macros to wrap in parenthesis to prevent macro expansion : issues as well. > Yeah, if it's easy enough to patch gtest like we've done for other bug fixe Fair enough. Would you be interested in doing that in a follow on change? I can take a look at some point too. Ideally we would then contribute the patch to glog itself. -- To view, visit http://gerrit.cloudera.org:8080/15924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652a852d040fcd3d974002382735610c8621c413 Gerrit-Change-Number: 15924 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 15 May 2020 19:45:37 +0000 Gerrit-HasComments: Yes
