Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16060 )

Change subject: [tests] add same_tablet_concurrent_writes test
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16060/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16060/2//COMMIT_MSG@24
PS2, Line 24: The rates of successful write operations was the same for both 
cases.
            : However, the number of messages from spinlock_profiling.cc like
            :   Waited 190 ms on lock 0x237acd4 ...
            : dropped significantly after applying patch 16034 on top.  That's 
a good
            : news to have less contention because the freed CPU resources 
might be
            : spend on something useful.
> can you compare a latency histogram, either from the point of view of the c
Done.

As expected, the latencies of Write RPC and apply haven't changed much: the 
main factor limiting the throughput in this scenario is extra latency added for 
every fsync() WAL operation.

However, lock contention and rpc_incoming_queue_time significantly lower with 
16034.



--
To view, visit http://gerrit.cloudera.org:8080/16060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eef6e46e7685450354473cee9d804c5054723eb
Gerrit-Change-Number: 16060
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Sat, 20 Jun 2020 03:14:12 +0000
Gerrit-HasComments: Yes

Reply via email to